Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename forceneutronsles12 to want_neutronsles12. #258

Merged
merged 2 commits into from
Mar 9, 2015

Conversation

aplanas
Copy link
Contributor

@aplanas aplanas commented Mar 5, 2015

No description provided.

@MaximilianMeister
Copy link
Contributor

could you please add this option as a comment to the undocumented options?

relates to the issue #256

@aplanas
Copy link
Contributor Author

aplanas commented Mar 5, 2015

@MaximilianMeister I added the variable and I ordered the list for a more easy reading.

@MaximilianMeister
Copy link
Contributor

👍 thanks

@aspiers
Copy link
Contributor

aspiers commented Mar 5, 2015

So -1 as it stands, but it should only take a few minutes to make the suggested changes and convert that into a +1 :)

@jsuchome
Copy link
Member

jsuchome commented Mar 9, 2015

+1

@aplanas
Copy link
Contributor Author

aplanas commented Mar 9, 2015

Separate the last commit in two commits

@aplanas
Copy link
Contributor Author

aplanas commented Mar 9, 2015

r? @aspiers

@aspiers
Copy link
Contributor

aspiers commented Mar 9, 2015

Sorry, still -1. It should add documentation rather than expand an existing TODO list. Also would prefer not to alphabetically sort the options since they are currently grouped logically which is more useful.

@aplanas
Copy link
Contributor Author

aplanas commented Mar 9, 2015

  • Remove the commit that order the undocumented variables.
  • Document want_neutronsles12 variable.

r? @aspiers

@aspiers
Copy link
Contributor

aspiers commented Mar 9, 2015

+1! :)

jsuchome added a commit that referenced this pull request Mar 9, 2015
Rename forceneutronsles12 to want_neutronsles12.
@jsuchome jsuchome merged commit 6c89c8a into SUSE-Cloud:master Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants