Some fixes for router migration #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 16, 2017 15:28
There was a bug when checking if the router has been removed - it was checking the router dict, whereas it should really check the ids.
We had 3 occurences of the above code, so it's time to extract that logic.
If a non-distributed router failed to move, we did 2 checks with no actions taken in between, removing the extra check.
We were raising the same RuntimeError from two places. Re-structured the code a bit to eliminate the code duplication.
aspiers
approved these changes
May 17, 2017
rhafer
suggested changes
May 19, 2017
There was a problem hiding this comment.
Looks good to me. Though while you're at it, could you also please fix the doc comments for list_routers_on_agent (https://github.com/SUSE-Cloud/cookbook-openstack-network/pull/33/files#diff-937ed0b9cba9efd2521c8fd1c9e8416fR851) it still says that it returns a list of router_ids.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some fixes of router migration. The most important change is that we might have falsely reported that a router was deleted from the source agents, because we were not checking the router ids, we were expecting to see the same router dictionary from different api requests. Also some cosmetics applied to the code while I was there.