Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for duplicate aria ids that are from the localization. #3485

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mcavady
Copy link

@mcavady mcavady commented May 23, 2024

PR Summary:

The issue was the snippet is in the drawer and the footer with the same id's.

Why are these changes introduced?

Fixes #0.
Duplicate ARIA ID's

What approach did you take?

Fix for duplicate aria ids that are from the localization, added in the localPosition to the id from the snippet rendering

id="country-filter-input

To

id="country-filter-input-search-{{ localPosition }}"

Other considerations

Will this break anything else

Decision log

# Decision Alternatives Rationale Downsides
1

Visual impact on existing themes

No Visual Change

Testing steps/scenarios

  • Run lighthouse check and see ARIA roles flag up
  • Search the DOM for the duplicate ID "id="country-filter-input", this will be in both the footer and the mobile nav if the currency / localisation is enabled

Demo links

Checklist

…he localPosition to the id

id="country-filter-input

To

id="country-filter-input-search-{{ localPosition }}"

Found this while lighthouse testing.

The issue was the snippet is in the drawer and the footer with the same id's
@mcavady
Copy link
Author

mcavady commented May 23, 2024

Job needs a re run now the Agreement is signed, How do I make that happen here please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant