Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
I have a re-implement test tap-i18n-db in javascript which is also tap:i18n independent. In order to verify original functionality, I need to user original unittest in my implementation. The problem is reactivity tests take so long time to run so I reworked them to make them become faster.
What I have done
Deps
in this case because they are old implementation. In my case, I changed them toTracker
) which would waste so much time waiting for the timer.The new unittest depends on
Meteor.subcribe.ready()
which will become not ready when tracker become invalidate and back to ready again when new data have arrived.The new running time are
Disclaimer
I haven't been testing on implementation with tap:i18n, only with mocked tap:i18n because the original one seem to be broken as hell, along with some modification in unittest starter file to include some missing dependencies. I had modified and run this test in Meteor 1.7.0.5. Even though the other part of unittests are also broken because the changes in the last 3-4 years which I have fixed in JS re-implementation. But this rework seem to be pretty useful in general so I submitted this PR.