Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temperature conversions #169

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

MaarcooC
Copy link

@MaarcooC MaarcooC commented Oct 3, 2024

Added 6 functions for temperature conversion between Celsius, Fahrenheit, and Kelvin with input validation.

@MaarcooC
Copy link
Author

MaarcooC commented Oct 4, 2024

added a function that checks if a number is perfect.

Copy link
Contributor

@darwinz darwinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR! Please add proper unit tests in the appropriate tests directory and location. Also, your code needs to be linted and tests passing first, so please run PHPCS (vendor/bin/phpcs -n)

@MaarcooC
Copy link
Author

MaarcooC commented Oct 7, 2024

Sorry for that, I now added proper unit tests and ran phpcs.

Copy link
Author

@MaarcooC MaarcooC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added unit tests and phpcs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants