Fix clippy::range_plus_one #1395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Bazel Dev / macos-13, Cargo Dev / macos-13, Installation / macos-13, Installation / macos-14, macos-13
adam-singer
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Not sure I exactly like this syntax for rust, tho if it is the idiomatic rust for clippy..
Reviewable status:
complete! 2 of 1 LGTMs obtained, and all files reviewed
adam-singer
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
SchahinRohani
force-pushed
the
fix/clippy-range_plus_one
branch
from
cb6e96f
to
f683605
Compare
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How Has This Been Tested?
bazel test ...Checklist
bazel test //...passes locallygit amendsee some docsThis change is