Handle empty file request on dedup store #1398
Open
+40
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
WillDoItMyself
had a problem deploying
to
production
GitHub Actions
Failure
WillDoItMyself
had a problem deploying
to
production
GitHub Actions
Failure
WillDoItMyself
force-pushed
the
dedup-store-handle-zero-digest
branch
from
f372e8d
to
c43cdbe
Compare
WillDoItMyself
had a problem deploying
to
production
GitHub Actions
Error
WillDoItMyself
had a problem deploying
to
production
GitHub Actions
Error
WillDoItMyself
force-pushed
the
dedup-store-handle-zero-digest
branch
from
c43cdbe
to
ec9e403
Compare
WillDoItMyself
had a problem deploying
to
production
GitHub Actions
Failure
WillDoItMyself
had a problem deploying
to
production
GitHub Actions
Error
WillDoItMyself
force-pushed
the
dedup-store-handle-zero-digest
branch
from
ec9e403
to
64baa70
Compare
WillDoItMyself
had a problem deploying
to
production
GitHub Actions
Error
WillDoItMyself
had a problem deploying
to
production
GitHub Actions
Failure
WillDoItMyself
force-pushed
the
dedup-store-handle-zero-digest
branch
from
64baa70
to
7e6c796
Compare
WillDoItMyself
temporarily deployed
to
production
GitHub Actions
Inactive
WillDoItMyself
temporarily deployed
to
production
GitHub Actions
Inactive
adam-singer
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained, and all files reviewed, and pending CI: Publish image
adam-singer
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
@allada was there any reason why empty digests wasn't checked on dedup store? I don't recall hitting this issue
Reviewable status: 1 of 2 LGTMs obtained, and all files reviewed, and pending CI: Publish image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1397
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
Added new test case in unit tests
Checklist
This change is