Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERS optimizations #265

Merged
merged 2 commits into from
Aug 27, 2024
Merged

ERS optimizations #265

merged 2 commits into from
Aug 27, 2024

Conversation

Saloed
Copy link
Collaborator

@Saloed Saloed commented Aug 27, 2024

[jacodb-core] Optimize CompactPersistentLongSet

[jacodb-core] Fix method names: getPropertyNames(), getBlobNames(), getLinkNames()

In SqlErsTransaction, TODO stub implementations added.

[jacodb-core] Optimize storing tiny blobs in RAMPersistentDataContainer

[jacodb-core] Correct code in Iinc5 test class

[jacodb-core] In SafeSubstitution, ignore substitution problems for unknown classes

[jacodb-core] Add test for try-catch blocks inside Kotlin inline lambda

[jacodb-core] Optimize CompactPersistentLongSet

[jacodb-core] Fix method names: getPropertyNames(), getBlobNames(), getLinkNames()

In SqlErsTransaction, TODO stub implementations added.

[jacodb-core] Optimize storing tiny blobs in RAMPersistentDataContainer

[jacodb-core] Correct code in Iinc5 test class

[jacodb-core] In SafeSubstitution, ignore substitution problems for unknown classes

[jacodb-core] Add test for try-catch blocks inside Kotlin inline lambda
Copy link
Contributor

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 56s ⏱️ -2s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit 449c8c3. ± Comparison against base commit 788d041.

Copy link
Contributor

Test results on JDK 19

   85 files     85 suites   15m 6s ⏱️
2 515 tests 2 474 ✅ 41 💤 0 ❌
2 543 runs  2 502 ✅ 41 💤 0 ❌

Results for commit 449c8c3.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 47.22222% with 19 lines in your changes missing coverage. Please review.

Project coverage is 58.80%. Comparing base (788d041) to head (449c8c3).
Report is 1 commits behind head on neo.

Files Patch % Lines
...org/jacodb/impl/types/substition/JcSubstitutors.kt 45.45% 2 Missing and 4 partials ⚠️
...codb-core/src/main/kotlin/org/jacodb/impl/Async.kt 25.00% 2 Missing and 1 partial ⚠️
...g/jacodb/impl/storage/ers/sql/SqlErsTransaction.kt 0.00% 3 Missing ⚠️
.../impl/storage/ers/decorators/AbstractDecorators.kt 0.00% 2 Missing ⚠️
...org/jacodb/impl/storage/ers/kv/KVErsTransaction.kt 0.00% 2 Missing ⚠️
.../org/jacodb/impl/storage/ers/ram/RAMTransaction.kt 0.00% 2 Missing ⚠️
...b/impl/storage/ers/ram/CompactPersistentLongSet.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #265      +/-   ##
============================================
- Coverage     58.84%   58.80%   -0.05%     
- Complexity     2288     2289       +1     
============================================
  Files           314      315       +1     
  Lines         18613    18611       -2     
  Branches       2983     2986       +3     
============================================
- Hits          10953    10944       -9     
- Misses         6569     6574       +5     
- Partials       1091     1093       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Test results on JDK 11

   85 files  +1     85 suites  +1   15m 54s ⏱️ - 1m 8s
2 515 tests +2  2 476 ✅ +2  39 💤 ±0  0 ❌ ±0 
2 543 runs  +2  2 504 ✅ +2  39 💤 ±0  0 ❌ ±0 

Results for commit 449c8c3. ± Comparison against base commit 788d041.

Copy link
Contributor

Test results on JDK 8

   85 files  +1     85 suites  +1   21m 22s ⏱️ -57s
2 515 tests +2  2 471 ✅ +2  44 💤 ±0  0 ❌ ±0 
2 543 runs  +2  2 499 ✅ +2  44 💤 ±0  0 ❌ ±0 

Results for commit 449c8c3. ± Comparison against base commit 788d041.

@Saloed Saloed merged commit 1abfc75 into neo Aug 27, 2024
8 of 10 checks passed
@Saloed Saloed deleted the saloed/patch branch August 27, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant