Implement export options. #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeberrex
requested changes
Feb 23, 2021
| private static Scaffold instance; | ||
| public static Scaffold instance; |
There was a problem hiding this comment.
I believe this is not needed as the getter method below is already public
| @@ -238,7 +238,7 @@ public static void upload(CommandContext cmd, CommandSender sender) { | |||
|
|
|||
| sender.sendMessage(ChatColor.YELLOW + "Uploading world..."); | |||
| try { | |||
| HttpResponse<String> response = Unirest.post("https://transfer.sh/").header("Max-Downloads", "1").header("Max-Days", "3").field("upload-file", zip).asString(); | |||
| HttpResponse<String> response = Unirest.post("https://transfer.sh/").header("Max-Downloads", Scaffold.get().getConfig().getString("export.maxdownloads")).header("Max-Days", Scaffold.get().getConfig().getString("export.maxdays")).field("upload-file", zip).asString(); | |||
There was a problem hiding this comment.
To reduce the width of this line, store the config retrieved from Scaffold.get().getConfig() into a local variable and provide a default value for the config paths you are requesting, as such: config.getString("export.maxdownloads", 1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the Server Administrator to customise the max downloads and days for worlds.