Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always do a full roundtrip in run-roundtrip.py #1661

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Always do a full roundtrip in run-roundtrip.py #1661

merged 1 commit into from
Mar 1, 2023

Commits on Feb 28, 2023

  1. Always do a full roundtrip in run-roundtrip.py

    Even when the result is to be printed rather than compared byte for byte
    with the first version its still good to process the resulting wat
    output file so that we know we can parse what we generate.
    
    Case in point, this changed caused me to fix two latent bugs:
    
    1. We were not correctly parsing events with inline import/export.
    2. We were output element segment names even when bulk memory
       was not enabled (See #1651)
    
    The fix for (2) is a little more involved that we might like since for
    the first time the wat writer needs to know what features are enabled.
    
    Fixes: #1651
    sbc100 authored and keithw committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    7fa5320 View commit details
    Browse the repository at this point in the history