Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm-interp: Handle Refs #2484

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

wasm-interp: Handle Refs #2484

wants to merge 3 commits into from
+72 −7

Conversation

SoniEx2
Copy link
Contributor

@SoniEx2 SoniEx2 commented Oct 5, 2024

This fills in some TODOs, may or may not be relevant for EHv4 but will definitely be relevant for GC later on.

We tried our best to make this efficient, hence the interpreter-only opcodes.

@SoniEx2 SoniEx2 mentioned this pull request Oct 5, 2024
Open
@SoniEx2
Copy link
Contributor Author

SoniEx2 commented Oct 7, 2024

@sbc100 (rebased, ptal)

@SoniEx2
Copy link
Contributor Author

SoniEx2 commented Oct 7, 2024 •
edited
Loading

oh yeah, we should probably bring it up: an alternative to the funny stuff with locals and refs_ would be to mark ref locals at function start, which would be decidedly faster if slightly more annoying to set up. but then again, we weren't really going for maximum performance with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SoniEx2