Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert local override on no_fdflags_sync_support #91

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Sep 22, 2023

  • I couldn't find this in wasmtime repo. I suppose this was a local modification done as a part of Port more tests from Wasmtime's testsuite #68

  • As some implementations have implemented it, it isn't appropriate to assert NOTSUP by default.

* I couldn't find this in wasmtime repo. I suppose this was
  a local modification done as a part of
  WebAssembly#68

* As some implementations have implemented it, it isn't appropriate
  to assert NOTSUP by default.
@loganek
Copy link
Collaborator

loganek commented Oct 2, 2023

I think this change is OK given that this is specifically for preview1 (because of the use of wasi crate).

I think we should also somehow keep track on the test configuration in test results, I've opened a ticket to discuss this: #93

@zoraaver
Copy link
Contributor

zoraaver commented Oct 3, 2023

Looks good, I'm just wondering whether we should assert the sync flag behaviour at all. The test which uses this is path_filestat.rs. Since the tests can't actually assert whether the sync flags work as intended, maybe we should remove that test instead? It has limited value and support is dependent on the host platform.

@loganek loganek merged commit 671aaab into WebAssembly:main Oct 5, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants