Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs: unify vertical tabs styles #65387

Open
wants to merge 58 commits into
base: trunk
Choose a base branch
from
Open

Tabs: unify vertical tabs styles #65387

wants to merge 58 commits into from
+127 −96

Commits on Sep 17, 2024

  1. Remove inserter pattern overrides

    @DaniGuardiola
    DaniGuardiola committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    1fe9f0b View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Merge branch 'trunk' of https://github.com/WordPress/gutenberg into i… 

    …mprove/unify-vertical-tabs-styles
    @DaniGuardiola
    DaniGuardiola committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    aa7e9d9 View commit details
    Browse the repository at this point in the history

  2. Make font weights 400 (inactive) and 500 (active)

    @DaniGuardiola
    DaniGuardiola committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a3e54c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Apply styles only when vertical.

    @DaniGuardiola
    DaniGuardiola committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0b436e8 View commit details
    Browse the repository at this point in the history

  2. Make vertical indicator theme accent color at 4% opacity.

    @DaniGuardiola
    DaniGuardiola committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    299d23c View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Make height 48px.

    @DaniGuardiola
    DaniGuardiola committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    30cda58 View commit details
    Browse the repository at this point in the history

  2. Add radius.

    @DaniGuardiola
    DaniGuardiola committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    4749518 View commit details
    Browse the repository at this point in the history

  3. Also use hover styles in focus-visible.

    @DaniGuardiola
    DaniGuardiola committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    4ba287f View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Fix indicator not visible in inserter > patterns/media.

    @DaniGuardiola
    DaniGuardiola committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7847ed6 View commit details
    Browse the repository at this point in the history

  2. Adjust padding.

    @DaniGuardiola
    DaniGuardiola committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c9e8020 View commit details
    Browse the repository at this point in the history

  3. Tweak focus ring.

    @DaniGuardiola
    DaniGuardiola committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0499718 View commit details
    Browse the repository at this point in the history

  4. Wrap long labels.

    @DaniGuardiola
    DaniGuardiola committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    77ce702 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Add chevron and fix a few minor details.

    @DaniGuardiola
    DaniGuardiola committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    23f5438 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Merge branch 'trunk' of https://github.com/WordPress/gutenberg into i… 

    …mprove/unify-vertical-tabs-styles
    @DaniGuardiola
    DaniGuardiola committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    5ffc33d View commit details
    Browse the repository at this point in the history

  2. Fix merge issues.

    @DaniGuardiola
    DaniGuardiola committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    fa2da0a View commit details
    Browse the repository at this point in the history

  3. Fix focus indicator (gets cropped with the new overflow auto setting)

    @DaniGuardiola
    DaniGuardiola committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    af857d3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'trunk' of https://github.com/WordPress/gutenberg into i… 

    …mprove/unify-vertical-tabs-styles
    @DaniGuardiola
    DaniGuardiola committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a8a3f3f View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Fix unwanted chevron.

    @DaniGuardiola
    DaniGuardiola committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    9867089 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Merge branch 'trunk' of https://github.com/WordPress/gutenberg into i… 

    …mprove/unify-vertical-tabs-styles
    @DaniGuardiola
    DaniGuardiola committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    bd0a96c View commit details
    Browse the repository at this point in the history

  2. Fix unwanted nested scrollbar in inserter > patterns/media vertical t… 

    …abs.
    @DaniGuardiola
    DaniGuardiola committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    56989af View commit details
    Browse the repository at this point in the history

  3. Switch to transform for performance.

    @DaniGuardiola
    DaniGuardiola committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    517950e View commit details
    Browse the repository at this point in the history

  4. Adjust border-radius based on scaling factor.

    @DaniGuardiola
    DaniGuardiola committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    a708e6b View commit details
    Browse the repository at this point in the history

  5. Apply feedback.

    @DaniGuardiola
    DaniGuardiola committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4aa21c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Add changelog entry.

    @DaniGuardiola
    DaniGuardiola committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    dcbd6f5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' of https://github.com/WordPress/gutenberg into i… 

    …mprove/unify-vertical-tabs-styles
    @DaniGuardiola
    DaniGuardiola committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    0a65888 View commit details
    Browse the repository at this point in the history

  3. Switch to padding-inline.

    @DaniGuardiola
    DaniGuardiola committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    f0902e8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'trunk' of https://github.com/WordPress/gutenberg into i… 

    …mprove/unify-vertical-tabs-styles
    @DaniGuardiola
    DaniGuardiola committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    e12afb5 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Remove unnecessary styles.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    535463c View commit details
    Browse the repository at this point in the history

  2. Fix horizontal tabs height.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3c43be8 View commit details
    Browse the repository at this point in the history

  3. Remove more unnecessary styles (padding).

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2d4bc91 View commit details
    Browse the repository at this point in the history

  4. Make horizontal padding specific to inline.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7f1e764 View commit details
    Browse the repository at this point in the history

  5. Make flex/whitespace styles more explicit.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    34cece9 View commit details
    Browse the repository at this point in the history

  6. Make scroll margin specific to vertical tabs.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3b82ba0 View commit details
    Browse the repository at this point in the history

  7. The "inline" in inline-flex is unnecessary and confusing, removed it.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    789545f View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary position: relative

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    094786c View commit details
    Browse the repository at this point in the history

  9. Make resets more explicit

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    87ce756 View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary text-align.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9808c75 View commit details
    Browse the repository at this point in the history

  11. Improve comment

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    74851f8 View commit details
    Browse the repository at this point in the history

  12. Remove unnecessary margin-left

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    cba3d80 View commit details
    Browse the repository at this point in the history

  13. Clean up TabList styles.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e6b902f View commit details
    Browse the repository at this point in the history

  14. Adjust text-align.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    41dc764 View commit details
    Browse the repository at this point in the history

  15. Clean up selector

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    cfc7928 View commit details
    Browse the repository at this point in the history

  16. Fix focus indicator

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d345ebd View commit details
    Browse the repository at this point in the history

  17. Clean up position: relative.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9c28772 View commit details
    Browse the repository at this point in the history

  18. Fix typo.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f831078 View commit details
    Browse the repository at this point in the history

  19. Add position: relative back.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b4f5c21 View commit details
    Browse the repository at this point in the history

  20. Improve focus indicator when selectOnMove is enabled.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a9b1578 View commit details
    Browse the repository at this point in the history

  21. Merge branch 'trunk' of https://github.com/WordPress/gutenberg into i… 

    …mprove/unify-vertical-tabs-styles
    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    5736e59 View commit details
    Browse the repository at this point in the history

  22. Add fade in effect to chevron when selectOnMove is enabled.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f4dbf4f View commit details
    Browse the repository at this point in the history

  23. Use [data-focus-visible] consistently.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    94f788b View commit details
    Browse the repository at this point in the history

  24. Styles clean up.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    01f31da View commit details
    Browse the repository at this point in the history

  25. Add comment for clarity.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4337d49 View commit details
    Browse the repository at this point in the history

  26. Move scroll-margin to the right place.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    01cefc9 View commit details
    Browse the repository at this point in the history

  27. Use CSS variable for accuracy.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    bb6b4e1 View commit details
    Browse the repository at this point in the history

  28. Fix overflow.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b6710f2 View commit details
    Browse the repository at this point in the history

  29. Skip failing test for Safari :(

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    822715b View commit details
    Browse the repository at this point in the history

  30. Fix flashing issue.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ece5efc View commit details
    Browse the repository at this point in the history

  31. Transition chevron only on selected and not on hover or focus-visible.

    @DaniGuardiola
    DaniGuardiola committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    07069c8 View commit details
    Browse the repository at this point in the history