Skip to content

Commit

Permalink
Merge pull request #3932 from Yelp/u/tmower/allow-setting-uses_bulkda…
Browse files Browse the repository at this point in the history
…ta-default-spark-PERES-4995

Further calls to uses_bulkdata default
  • Loading branch information
timmow authored Aug 20, 2024
2 parents ee4a3e8 + 46203da commit e492f59
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 4 additions & 1 deletion paasta_tools/cli/cmds/local_run.py
Original file line number Diff line number Diff line change
Expand Up @@ -1209,7 +1209,10 @@ def configure_and_run_docker_container(
if pull_image:
docker_pull_image(docker_url)

for volume in instance_config.get_volumes(system_paasta_config.get_volumes()):
for volume in instance_config.get_volumes(
system_paasta_config.get_volumes(),
system_paasta_config.get_uses_bulkdata_default(),
):
if os.path.exists(volume["hostPath"]):
volumes.append(
"{}:{}:{}".format(
Expand Down
5 changes: 4 additions & 1 deletion paasta_tools/cli/cmds/spark_run.py
Original file line number Diff line number Diff line change
Expand Up @@ -1189,7 +1189,10 @@ def paasta_spark_run(args: argparse.Namespace) -> int:
if docker_image_digest is None:
return 1

volumes = instance_config.get_volumes(system_paasta_config.get_volumes())
volumes = instance_config.get_volumes(
system_paasta_config.get_volumes(),
system_paasta_config.get_uses_bulkdata_default(),
)
app_base_name = get_spark_app_name(args.cmd or instance_config.get_cmd())

user_spark_opts = _parse_user_spark_args(args.spark_args)
Expand Down

0 comments on commit e492f59

Please sign in to comment.