Add separate fileprefix handlers for vitess crs #3935
Merged
+962
−974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinaySagarGonabavi
requested review from
siadat,
jfongatyelp,
flopex,
matt-ullmer and
alexanderjulianmartinez
VinaySagarGonabavi
requested review from
nemacysts
and removed request for
jfongatyelp
flopex
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
status would be broken for vitesscluster (which is fine) will fix in a later PR
Sample yelpsoa configs:
vitesscluster-infrastage-* https://fluffy.yelpcorp.com/i/n3JX00g4F596PXDCKlL4JHsRNBJsgFZC.html
vitesscell-infrastage-* https://fluffy.yelpcorp.com/i/Bt6lmxqFN9r6Xr5VjCqlxNL1js0tc4jM.html
vitesskeyspace-infrastage-* https://fluffy.yelpcorp.com/i/L5kL1WxrS550j4BJ2hbNM4cdtNgW5Mlw.html
Produced sample CR config:
vitess-k8s-vitess-control-plane: https://fluffy.yelpcorp.com/i/nrq3fJndhrWN0DthBFFx7KHJ1bqx8lSG.html
vitess-k8s-vtgate-uswest1adevc: https://fluffy.yelpcorp.com/i/L2GmQFMMmJd3VKbDT2bK64m6bsFhxRRn.html
vitess-k8s-yelp_vitess_testing_environment: https://fluffy.yelpcorp.com/i/TTsHHVrDvzzKhQ3dpNn3LQR0KxS3JG4Q.html