Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and document new fields for default endpoint alerting #3976

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Add and document new fields for default endpoint alerting #3976

merged 2 commits into from
Oct 2, 2024

Conversation

thejoycekung
Copy link
Contributor

  • Added default_endpoint_alerting to the example for idk, spice of life?
  • Updated the descriptions for namespace-level error_threshold_ratio + minimum_error_rps
  • Added descriptions for default_endpoint_alerting, endpoint_error_threshold_ratio, and endpoint_minimum_error_rps
  • Added those three fields to the schema file as well

@thejoycekung thejoycekung requested a review from a team as a code owner October 2, 2024 20:32
@thejoycekung thejoycekung merged commit 4854ceb into master Oct 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtbentley mtbentley mtbentley approved these changes

@cuza cuza cuza approved these changes

@ahaswell ahaswell Awaiting requested review from ahaswell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thejoycekung @mtbentley @cuza