Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unittests #32

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add unittests #32

wants to merge 11 commits into from

Conversation

Nakaner
Copy link
Contributor

@Nakaner Nakaner commented Jun 28, 2018

This pull request add some basic unit test for the calculation of the map size, bounding box, scale etc. based on the command line arguments. The unit tests are not complete. Instead, this pull request aims to make the code testable by adding a new class Nik4Image. Otherwise this pull request would become larger than it already is.

This pull request depends on #30 but I am open to rebase it on any other bug fix commit which does the same as #30

See also #31

@cheshire-mouse
Copy link

I think, it would be better if Nik4Image class contained everything related to calculations and image building (including run function) and some separate function did argument parsing. This could make possible to use Nik4 as a python module.
It, probably, has nothing to do with unit testing, but since you created a class...

@Nakaner
Copy link
Contributor Author

Nakaner commented Jul 11, 2018

That's my plan for the next pull request but I did not want to change whole Nik4 in one go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants