Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): removed dual placeholder logic from select #2329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Powerplex
Copy link
Contributor

Select.Value placeholder prop has been removed

BREAKING CHANGE: prop removal - placeholder of Select.Value

TASK: #2314

Description, Motivation and Context

Having both placeholder prop on Select.Value and Select.Placeholder is confusing to consumers.

I removed the prop on Select.Value, but Select.Placeholder now manages hidden and disabled attributes to fine-tune placeholder behaviour like on a native HTML option.

Also, made the placeholder of Dropdown.Value optional.

Types of changes

  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation

Screenshots - Animations

Enregistrement.de.l.ecran.2024-07-29.a.12.21.47.mov

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (d1f04c3) to head (9629c9c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2329   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         493      493           
  Lines        4141     4142    +1     
  Branches     1342     1306   -36     
=======================================
+ Hits         3995     3996    +1     
  Misses        144      144           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Select.Value placeholder prop has been removed

BREAKING CHANGE: prop removal - placeholder of Select.Value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: select Related to alert-dialog component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants