Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add after validation hooks #252

Closed
wants to merge 16 commits into from
Closed

Add after validation hooks #252

wants to merge 16 commits into from

Conversation

ahx
Copy link
Owner

@ahx ahx commented Mar 25, 2024 •
edited
Loading

This refactors some things in order to implement hooks. This is work in progress.

  • Hooks:
    • after_request_validation
    • after_response_validation
    • after_request_body_property_validation
    • after_request_parameter_property_validation

Related to #207

ahx added 16 commits March 25, 2024 21:40
@ahx
Pass validator object to request and response instead of the openapi_…
152962e 
…version
@ahx
Remove unused Operation#schema_for
cfb51b4
@ahx
Make Operation simpler. Move schema building into Validator
843a19f
@ahx
Optimize: Don't instantiate response validator unless needed
184e69a
@ahx
Remove superflous memoization
691db76 
This had no impact on ip/s performance and its simpler this way
@ahx
Update changelog
63b72ea
@ahx
Add after_request_validation, after_response_validation hooks
d1578b0
@ahx
Avoid warning from committee
71334b3
@ahx
Use public API in middlewares
907d194 
This also removes a cheat in the benchmarks
@ahx
Freeze configuration
ff643fb
@ahx
Add hooks
1bae9a5
@ahx
Update Changelog, Readme
7217792
@ahx
Re-add code after rebase
5bdaec9
@ahx
Remove useless codepath in test
efedcfa
@ahx
Remove unused let in test
5216ce2
@ahx
Update changelog
062b3ca
@ahx ahx marked this pull request as draft March 25, 2024 21:13
@ahx ahx changed the title Add hooks Add after validation hooks Mar 25, 2024
@ahx
Copy link
Owner Author

ahx commented Mar 27, 2024

Closing this for now. Will come back to it later.

@ahx ahx closed this Mar 27, 2024
@ahx ahx deleted the add-hooks branch April 7, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ahx