Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add jbook *.yml's #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add jbook *.yml's #16

wants to merge 1 commit into from

Conversation

MichaelClifford
Copy link
Member

@MichaelClifford MichaelClifford commented Jul 20, 2021 •
edited
Loading

add the _toc.yml and _config.yml

closes #14

@sesheta
Copy link
Contributor

sesheta commented Jul 20, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign durandom after the PR has been reviewed.
You can assign the PR to them by writing /assign @durandom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 20, 2021
@chauhankaranraj
Copy link
Member

/lgtm 🚀

oindrillac
oindrillac reviewed Jul 20, 2021
View reviewed changes
_toc.yml
format: jb-book
root: README
parts:
- caption: Behind the Scenes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to modify this to follow the new proposed structure?

_config.yml

# Information about where the book exists on the web
repository:
url: https://github.com/AICoE/elyra-aidevsecops-tutorial # Online location of your book
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this point to this repository now?

isabelizimm
isabelizimm reviewed Jul 20, 2021
View reviewed changes
_config.yml
@@ -0,0 +1,31 @@
title: Project Meteor
author: Shooting Star
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep this title/author? Maybe Meteor Demo with author AICoE or something along those lines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oindrillac oindrillac oindrillac left review comments

@isabelizimm isabelizimm isabelizimm left review comments

@durandom durandom Awaiting requested review from durandom durandom is a code owner

@tumido tumido Awaiting requested review from tumido tumido is a code owner

@chauhankaranraj chauhankaranraj Awaiting requested review from chauhankaranraj

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add toc and config files
5 participants
@MichaelClifford @sesheta @chauhankaranraj @oindrillac @isabelizimm