Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export paths #16

Closed
wants to merge 1 commit into from
Closed

Export paths #16

wants to merge 1 commit into from

Conversation

mygnu
Copy link

@mygnu mygnu commented May 4, 2020

closes #4

algesten
algesten approved these changes May 6, 2020
View reviewed changes
Copy link
Owner

@algesten algesten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✨

@algesten
Copy link
Owner

algesten commented May 6, 2020

@mygnu The branch has some conflicts. Maybe drop the dependency update since I like doing that myself?

@algesten algesten mentioned this pull request May 6, 2020
Closed
@mygnu
Copy link
Author

mygnu commented May 6, 2020

Thanks rebased on current master

@algesten algesten mentioned this pull request May 7, 2020
Open
@algesten
Copy link
Owner

algesten commented May 7, 2020

@mygnu Since both your PR are about opening up acme-lib to allow for some different usage, I assume this is to do with the persistence? What is the problem with the Persist trait? Can we discuss it more generally in #18?

@mygnu mygnu closed this May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algesten algesten algesten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add a method for obtaining the paths to keys and certificates on disk
2 participants
@mygnu @algesten