Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for remote tier and ILM transition #565

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

s2thudry
Copy link
Contributor

@s2thudry s2thudry commented Jun 11, 2024

Add support for remote tier and ILM transition

This PR implements the following changes:

  • add new resource minio_ilm_tier
  • support transition in minio_ilm_policy

This was only tested locally with multiple MinIO, I haven't tested with Azure, GCP or AWS.
This is my first time working with a Terraform provider so don't hesitate to tell me if some things are not done the proper way.

Regarding the sensitives values, it seems that madmin only return "REDACTED" so I added a parameter to for the edit of credential if set and ignore the constant diff between what madmin return and the actual sensitive value, let me know if this is ok for you or if you'd prefer I handle it differently.

Reference

Closing issues

@s2thudry s2thudry marked this pull request as ready for review June 11, 2024 06:37
@felladrin
Copy link
Collaborator

Thank you for this addition, @s2thudry! And congrats on your first contribution to this repo! 🎉

@felladrin felladrin merged commit 1034b3b into aminueza:main Jun 14, 2024
2 checks passed
@s2thudry s2thudry deleted the feature/ilm_tier_transition branch June 14, 2024 08:08
szinn referenced this pull request in szinn/k8s-homelab Jun 14, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [minio](https://registry.terraform.io/providers/aminueza/minio)
([source](https://togithub.com/aminueza/terraform-provider-minio)) |
required_provider | minor | `2.2.1` -> `2.3.0` |

---

### Release Notes

<details>
<summary>aminueza/terraform-provider-minio (minio)</summary>

###
[`v2.3.0`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v2.3.0)

[Compare
Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v2.2.1...v2.3.0)

#### What's Changed

- Add support for remote tier and ILM transition by
[@&#8203;s2thudry](https://togithub.com/s2thudry) in
[https://github.com/aminueza/terraform-provider-minio/pull/565](https://togithub.com/aminueza/terraform-provider-minio/pull/565)

#### New Contributors

- [@&#8203;s2thudry](https://togithub.com/s2thudry) made their first
contribution in
[https://github.com/aminueza/terraform-provider-minio/pull/565](https://togithub.com/aminueza/terraform-provider-minio/pull/565)

**Full Changelog**:
aminueza/terraform-provider-minio@v2.2.1...v2.3.0

</details>

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MDguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQwOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL21pbm9yIl19-->

Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
kireque referenced this pull request in kireque/home-ops Jun 14, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [minio](https://registry.terraform.io/providers/aminueza/minio)
([source](https://togithub.com/aminueza/terraform-provider-minio)) |
required_provider | minor | `2.2.1` -> `2.3.0` |

---

### Release Notes

<details>
<summary>aminueza/terraform-provider-minio (minio)</summary>

###
[`v2.3.0`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v2.3.0)

[Compare
Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v2.2.1...v2.3.0)

#### What's Changed

- Add support for remote tier and ILM transition by
[@&#8203;s2thudry](https://togithub.com/s2thudry) in
[https://github.com/aminueza/terraform-provider-minio/pull/565](https://togithub.com/aminueza/terraform-provider-minio/pull/565)

#### New Contributors

- [@&#8203;s2thudry](https://togithub.com/s2thudry) made their first
contribution in
[https://github.com/aminueza/terraform-provider-minio/pull/565](https://togithub.com/aminueza/terraform-provider-minio/pull/565)

**Full Changelog**:
aminueza/terraform-provider-minio@v2.2.1...v2.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MDguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQwOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS90ZXJyYWZvcm0iLCJ0eXBlL21pbm9yIl19-->

Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ilm] tier transitioning
2 participants