Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

refactor(colors): clean up Closure / JSDoc comments and types #11676

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

Splaktar
Copy link
Member

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The Closure types / JSDoc in md-colors and util/colors is very inconsistent and/or missing. There are quite a few typos.

Issue Number:
Relates to #11673

What is the new behavior?

  • Clean up typos.
  • The Closure types / JSDoc in md-colors and util/colors are much more helpful and organized.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Splaktar Splaktar added this to the 1.1.14 milestone Mar 13, 2019
@Splaktar Splaktar self-assigned this Mar 13, 2019
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Mar 13, 2019
@Splaktar Splaktar added P4: minor Minor issues. May not be fixed without community contributions. type: chore pr: merge ready This PR is ready for a caretaker to review labels Mar 13, 2019
@mmalerba mmalerba merged commit b9b63f9 into master Mar 14, 2019
@Splaktar Splaktar deleted the colors-ClosureCleanup branch March 14, 2019 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review type: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants