Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more information about tasks to event_data #1227 #1233

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

NaincyKumariKnoldus
Copy link

Hi!! I have updated /ansible_runner/display_callback/callback/awx_display.py. Added more information about tasks to event_data as you have mentioned.

task_ctx = dict( task=(task.name or task.action), task_uuid=str(task._uuid), task_action=task.action, task_check_mode=task.check_mode, resolved_action=getattr(task, 'resolved_action', task.action), task_args='', )

Please review this PR and merge it. If any changes still required please do let me know.

Thanks!
#1227

@NaincyKumariKnoldus NaincyKumariKnoldus requested a review from a team as a code owner April 14, 2023 11:28
@nitzmahone
Copy link
Member

Given that most tasks aren't in check mode most of the time, maybe this key should only be added if the task is in check mode and callers can assume its absence as False. Otherwise this further bloats up the already quite-large event payloads with data that most people don't need.

@Akasurde
Copy link
Member

@NaincyKumariKnoldus Thanks for the PR. Could you please address @nitzmahone's review and also add a test for this change? Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants