This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
feat!: add unwasm condition in exports
#72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shikiji ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
antfu
commented
Jan 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
- Coverage 96.92% 96.92% -0.01%
==========================================
Files 49 49
Lines 4196 4193 -3
Branches 521 522 +1
==========================================
- Hits 4067 4064 -3
Misses 127 127
Partials 2 2 ☔ View full report in Codecov by Sentry. |
antfu
changed the title
auto.wasm entryunwasm entry in exports
pi0
reviewed
Jan 2, 2024
| @@ -43,7 +43,7 @@ const highlighter = await getHighlighterCore({ | |||
| langs: [ | |||
| import('shikiji/langs/javascript.mjs'), | |||
| ], | |||
| loadWasm: getWasmInlined | |||
| loadWasm: getWasm | |||
There was a problem hiding this comment.
Totally up to you, but wouldn't using loadWasm as import name allow loadWasm shorthand syntax?
There was a problem hiding this comment.
The reason we have a different name here is that loadWasm is an exported function, and we could have usage like:
import { loadWasm } from 'shikiji/core'
import getWasm from 'shikiji/wasm'
await loadWasm(getWasm)| const getWasm: WebAssemblyInstantiator = async (info) => { | ||
| // @ts-expect-error this will be compiled to ArrayBuffer | ||
| const binray: ArrayBuffer = await import('vscode-oniguruma/release/onig.wasm').then(m => m.default) | ||
| return WebAssembly.instantiate(binray, info).then(wasm => wasm.instance.exports) |
antfu
changed the title
unwasm entry in exportsunwasm condition in exports
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #71, awaits unjs/unwasm#10
Breaking Changes
shikiji/wasmandshikiji-core/wasmnow only have default exports, name exportgetWasmInlinedis removedshikiji-core/wasmrenamed toshikiji-core/wasm-inlined