Add new column last_id to the table volumes
#9759
Conversation
…it easier to track volumes after their migration
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9759 +/- ##
============================================
- Coverage 15.11% 15.08% -0.04%
+ Complexity 11184 11182 -2
============================================
Files 5402 5402
Lines 473120 473201 +81
Branches 58327 58109 -218
============================================
- Hits 71507 71363 -144
- Misses 393812 393900 +88
- Partials 7801 7938 +137
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11265 |
| @@ -48,6 +48,9 @@ public class VolumeVO implements Volume { | |||
| @Column(name = "id") | |||
| long id; | |||
|
|
|||
| @Column(name = "previous_id") | |||
There was a problem hiding this comment.
@FelipeM525 thanks for the PR, LGTM. Minor nit - could we call it last_id ? or last_uuid? This is because in the DB schema, there are many last... columns.
DaanHoogland
changed the title
previous_id to the table volumeslast_id to the table volumes
Description
In ACS Once a volume is migrated, it duplicates its row in the database and labels the previous one as removed; however, there is no reference to the deleted row, making it so the operator is unable to track the previous volume effectively. This PR aims to change this by adding a new column to the table volumes called
last_id.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
This PR was tested by live migrating VM with storage and also by migrating a volume with the VM turned off; in both cases, the new column was populated accordingly.