Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gateway to work with Application Load Balancer with Multi Value Headers enabled #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ec-kelsey
Copy link

We have been using gateway with go-gin and recently swapped from using an API Gateway to an ALB for routing, which worked fine. However, when trying to turn multi value headers on the site broke when run through gateway.
I have discovered that the multi value headers were being set with lower case header names, which was not being picked up using Header.Get, and that the ALB expects all header values to be returned in the multi value headers when using this mode.

My testing suggests that this should not break anything when running without multi value headers enabled as before.

@ec-kelsey
Copy link
Author

Tests have failed due to output being changed slightly, but it looks like that when multi value headers are not being used the contents should be ignored.

@ben-anscombe
Copy link

I'd like to add a +1 to this PR, we are facing the same issue and it is causing this version of apex gateway to unfortunately be unusable for us and we have had to downgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants