Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding allow list #147

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

sulrich
Copy link
Contributor

@sulrich sulrich commented Aug 5, 2024

adding allow-list entry to address a false-positive in the secrets scanner.

@sulrich sulrich self-assigned this Aug 5, 2024
@sulrich
Copy link
Contributor Author

sulrich commented Aug 5, 2024

/secret-scanner apply allow list

@arista-secret-scanner
Copy link

Run 10257219399 scheduled. Result will be posted here when finished.

@arista-secret-scanner
Copy link

Allow list Summary

  • Total number of secrets in repo: 2
  • Allowed secrets: 1
  • Disallowed secrets: 1
  • Unused allow list entries: 0
Secrets allowed
{
    "repository": "aristanetworks/openmgmt",
    "commit_hash": "53334b41900ea92f9a140086dfcaa116cb7368b9",
    "file_path": "docs/examples/mtls/index.md",
    "raw_secret": "-set-up-and-configure-a-certificate-authority-ca-on-ubuntu-20-04",
    "vcs": "github",
    "job_id": null,
    "allowed": true,
    "line_number": 160,
    "bug_id": null,
    "detector": "DigitalOceanToken",
    "author": "steve ulrich <[email protected]>"
}
Secrets disallowed
{
    "repository": "aristanetworks/openmgmt",
    "commit_hash": "cd510888b4161816708e3ae56dd39b4edd0a972b",
    "file_path": "examples/gnmi-gateway/server.key",
    "raw_secret": "-----BEGIN EC PRIVATE KEY-----\nMIGkAgEBBDDwRqEoQcYEN9ii01RjO1G3Wm+u+8wwXOw9UORVqIc8TSqbzhu8oyRY\n6KeU92YmujCgBwYFK4EEACKhZANiAAQqzrinK2P9BVy/GB+HqOlwN+ZHDQjIjUSY\nrwC5/Y6drOPbHzTTeArZihJVnjUsRW/NifxOMqYnrRjft36sIO96/buTG6M/4+rH\nXJvG2ep4fWJlna2lOqPtrjvZbiGHMSw=\n-----END EC PRIVATE KEY-----\n",
    "vcs": "github",
    "job_id": null,
    "allowed": false,
    "line_number": 4,
    "bug_id": null,
    "detector": "PrivateKey",
    "author": "burnyd <[email protected]>"
}
Unused allow list entries

Details: https://github.com/aristanetworks/secret-scanner-service/actions/runs/10257219399

@sulrich
Copy link
Contributor Author

sulrich commented Aug 5, 2024

/secret-scanner apply allow list

@arista-secret-scanner
Copy link

Run 10257498984 scheduled. Result will be posted here when finished.

@arista-secret-scanner
Copy link

Allow list Summary

  • Total number of secrets in repo: 2
  • Allowed secrets: 1
  • Disallowed secrets: 1
  • Unused allow list entries: 0
Secrets allowed
{
    "repository": "aristanetworks/openmgmt",
    "commit_hash": "53334b41900ea92f9a140086dfcaa116cb7368b9",
    "file_path": "docs/examples/mtls/index.md",
    "raw_secret": "-set-up-and-configure-a-certificate-authority-ca-on-ubuntu-20-04",
    "vcs": "github",
    "job_id": null,
    "allowed": true,
    "line_number": 160,
    "bug_id": null,
    "detector": "DigitalOceanToken",
    "author": "steve ulrich <[email protected]>"
}
Secrets disallowed
{
    "repository": "aristanetworks/openmgmt",
    "commit_hash": "cd510888b4161816708e3ae56dd39b4edd0a972b",
    "file_path": "examples/gnmi-gateway/server.key",
    "raw_secret": "-----BEGIN EC PRIVATE KEY-----\nMIGkAgEBBDDwRqEoQcYEN9ii01RjO1G3Wm+u+8wwXOw9UORVqIc8TSqbzhu8oyRY\n6KeU92YmujCgBwYFK4EEACKhZANiAAQqzrinK2P9BVy/GB+HqOlwN+ZHDQjIjUSY\nrwC5/Y6drOPbHzTTeArZihJVnjUsRW/NifxOMqYnrRjft36sIO96/buTG6M/4+rH\nXJvG2ep4fWJlna2lOqPtrjvZbiGHMSw=\n-----END EC PRIVATE KEY-----\n",
    "vcs": "github",
    "job_id": null,
    "allowed": false,
    "line_number": 4,
    "bug_id": null,
    "detector": "PrivateKey",
    "author": "burnyd <[email protected]>"
}
Unused allow list entries

Details: https://github.com/aristanetworks/secret-scanner-service/actions/runs/10257498984

Copy link
Contributor

@fredhsu fredhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@sulrich sulrich merged commit 5de3087 into aristanetworks:main Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants