-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create share button with custom chooser. #11
base: master
Are you sure you want to change the base?
Conversation
@@ -401,6 +400,14 @@ public void setGravity(int gravity) { | |||
mGravity = gravity; | |||
} | |||
|
|||
// TODO is it the correct way to get currently shown card? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alouanemed I think @akhyrul is not sure how to get the currently shown card (when you tap to share).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aaah yeah we have getItem() inside CustomAdapter class ,you can use that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry I didn't check that. Thanks!
@akhyrul, @alouanemed may be able to help you with getting the correct card. @akhyrul when this PR is complete, can you please take a screenshot? |
} | ||
|
||
private void share(CardModel cardModel) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you are using CardModel instead of CustomCardModel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, base CardModel doesn't have image url. We are sharing this, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does
It's all good so far , don't forget to add the the drawer menu and actionBar |
@akhyrul how this is going ? |
Ping @akhyrul :D |
@alouanemed, i can take this bounty if @akhyrul will not answer :D |
@DanilinEgor , Let's give @akhyrul sometime :D .I have another bounty for you |
Still not completed: