Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create share button with custom chooser. #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akhy
Copy link

@akhy akhy commented Feb 19, 2015

Still not completed:

  • Share button icon
  • Share activity design (assets required)
  • Item shared is still wrong. Can't figure out how to get the correct one (see code comment)

@@ -401,6 +400,14 @@ public void setGravity(int gravity) {
mGravity = gravity;
}

// TODO is it the correct way to get currently shown card?
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alouanemed I think @akhyrul is not sure how to get the currently shown card (when you tap to share).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaah yeah we have getItem() inside CustomAdapter class ,you can use that

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry I didn't check that. Thanks!

@bshyong
Copy link
Contributor

bshyong commented Feb 19, 2015

@akhyrul, @alouanemed may be able to help you with getting the correct card.

@akhyrul when this PR is complete, can you please take a screenshot?

@alouanemed
Copy link
Contributor

@bshyong @akhyrul I will check it :)

And please @akhyrul take screenshot of your work to so the others able to see your work :)

}

private void share(CardModel cardModel) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you are using CardModel instead of CustomCardModel

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, base CardModel doesn't have image url. We are sharing this, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does

@alouanemed
Copy link
Contributor

It's all good so far , don't forget to add the the drawer menu and actionBar

@alouanemed
Copy link
Contributor

@akhyrul how this is going ?

@alouanemed
Copy link
Contributor

Ping @akhyrul :D

@DanilinEgor
Copy link
Contributor

@alouanemed, i can take this bounty if @akhyrul will not answer :D

@alouanemed
Copy link
Contributor

@DanilinEgor , Let's give @akhyrul sometime :D .I have another bounty for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants