Skip to content
This repository has been archived by the owner on Aug 25, 2024. It is now read-only.

feat: add Swift modules and an iOS application #3

Merged
merged 43 commits into from
Oct 4, 2023

Conversation

cgrindel
Copy link

@cgrindel cgrindel commented Oct 3, 2023

Type of change

Add Swift modules and an iOS application to the repository to demonstrate:

Chores

  • Update Bazel version to 6.3.2.
  • Update Go dependencies to latest.
  • Update Gazelle declaration to include Swift plugin.

Test plan

  • New test cases added

Unit tests can be run using bazel test //.... The UI tests for the iOS application can be run using bazel test //ios/LoggingClient/UITests.

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2023

CLA assistant check
All committers have signed the CLA.

@cgrindel cgrindel marked this pull request as ready for review October 3, 2023 15:26
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cgrindel
Copy link
Author

cgrindel commented Oct 3, 2023

@alexeagle When you get a chance, could you approve the workflow? I have the tests working on MacOS and Ubuntu. I just want to be sure that the CI works properly.

@cgrindel
Copy link
Author

cgrindel commented Oct 4, 2023

@alexeagle I just updated the bazelrc to output more info about the UITest failure in CI. Could you approve the workflow?

@alexeagle
Copy link
Member

I turned off that setting for now, I didn't mean to block your PRs on that approval!

@alexeagle alexeagle merged commit d9583eb into aspect-build:final Oct 4, 2023
4 checks passed
@cgrindel cgrindel deleted the ios_app branch October 4, 2023 16:26
@cgrindel
Copy link
Author

cgrindel commented Oct 4, 2023

I guess that UI test failure did not occur again. 🤷‍♂️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants