Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixup failing assert_contains test #192

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .aspect/workflows/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,8 @@ tasks:
buildifier:
gazelle:
test:
bazel:
flags:
- --instrumentation_filter=-//jest/tests/fixed_args:fixed_args_test
coverage: true
upload_test_logs: executed
3 changes: 2 additions & 1 deletion jest/private/jest_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ def _impl(ctx):
"--config",
# quote the path since it might have special chars such as parens.
# quoting ensures that the shell doesn't do any globbing or splitting.
"'" + paths.join(unwind_chdir_prefix, generated_config.short_path) + "'",
# NB: intentionally use double quotes
"\"" + paths.join(unwind_chdir_prefix, generated_config.short_path) + "\"",
])
if ctx.attr.log_level == "debug":
fixed_args.append("--debug")
Expand Down