Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR]: ts_proto_library #415

Closed
alexeagle opened this issue Aug 18, 2023 · 2 comments
Closed

[FR]: ts_proto_library #415

alexeagle opened this issue Aug 18, 2023 · 2 comments
Assignees
@alexeagle @thesayyn
Labels
enhancement New feature or request
Milestone
2.0

Comments

@alexeagle
Copy link
Member

What is the current behavior?

Protocol Buffers and gRPC are mostly undocumented in rules_ts. Aspect has https://github.com/aspect-build/bazel-examples/tree/c8ba84f4a21038cc0d577f1a73570b330f579da3/protobufjs but there is a ts_proto_library defined there which users would rather have upstream.

Describe the feature

  1. "pick a winner" among the many options for generating the TS/JS code from .proto
  2. Add a ts_proto_library rule to the public API
  3. Show through examples that it works for messages and services in both Node.js servers and in a browser.
@alexeagle alexeagle added the enhancement New feature or request label Aug 18, 2023
@alexeagle alexeagle added this to the 2.0 milestone Aug 18, 2023
@github-actions github-actions bot added the untriaged Requires traige label Aug 18, 2023
@alexeagle
Copy link
Member Author

FYI @gonzojive

This was referenced Aug 18, 2023
Closed
Closed
@alexeagle alexeagle removed the untriaged Requires traige label Aug 23, 2023
@alexeagle alexeagle mentioned this issue Aug 23, 2023
Merged
@alexeagle
Copy link
Member Author

Added in #412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexeagle alexeagle

@thesayyn thesayyn

Labels
enhancement New feature or request
Projects
Open Source
Archived in project
Milestone
2.0
Development

No branches or pull requests
2 participants
@alexeagle @thesayyn