Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce ts_proto_library #412

Merged
merged 17 commits into from
Aug 23, 2023
Merged

feat: introduce ts_proto_library #412

merged 17 commits into from
Aug 23, 2023

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented Aug 17, 2023 •
edited
Loading

Type of change

  • New feature or functionality (change which adds functionality)

For changes visible to end-users

  • Relevant documentation has been updated: see new proto.md

Test plan

  • New test cases added

Fixes #415

@alexeagle alexeagle force-pushed the ts_proto_library branch 2 times, most recently from 9e24645 to 9020c27 Compare August 18, 2023 14:18
thesayyn
thesayyn reviewed Aug 21, 2023
View reviewed changes
ts/proto.bzl Outdated Show resolved Hide resolved
@alexeagle alexeagle marked this pull request as ready for review August 23, 2023 18:33
@thesayyn thesayyn self-requested a review August 23, 2023 19:01
@alexeagle alexeagle merged commit e5932f8 into 2.x Aug 23, 2023
24 of 28 checks passed
@alexeagle alexeagle deleted the ts_proto_library branch August 23, 2023 22:10
@alexeagle alexeagle mentioned this pull request Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesayyn thesayyn thesayyn approved these changes

@jbedard jbedard Awaiting requested review from jbedard

@gregmagolan gregmagolan Awaiting requested review from gregmagolan

Assignees
No one assigned
Labels
None yet
Projects
Open Source
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @thesayyn