fix: always declare ts_project_rule as primary ts_project target #710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
ts_project
macro produce more consistent underlying targets. The{name}
target will now be ats_project_rule
100% of the time. The only conditional logic is the the same as today: the addition of{name}_types
,{name}_typecheck
,{name}_typecheck_test
.We can maybe think of adding those 3 extra targets 100% of the time in the future (or maybe only doing
{name}_types
100% of the time and adding the test only when{name}
will not run tsc?).Changes are visible to end-users: no
Test plan