test: fixed clock tests in secure credential manager tests

auth0 · Jul 8, 2024 · dfa566a · dfa566a
1 parent d1f3912
commit dfa566a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/auth0/src/main/java/com/auth0/android/authentication/storage/SecureCredentialsManager.kt b/auth0/src/main/java/com/auth0/android/authentication/storage/SecureCredentialsManager.kt
@@ -32,8 +32,8 @@ public class SecureCredentialsManager @VisibleForTesting(otherwise = VisibleForT
     storage: Storage,
     private val crypto: CryptoUtil,
     jwtDecoder: JWTDecoder,
+    private val localAuthenticationManagerFactory: LocalAuthenticationManagerFactory,
     private val serialExecutor: Executor,
-    private val localAuthenticationManagerFactory: LocalAuthenticationManagerFactory
 ) : SecuredCredentialsManager(apiClient, storage, jwtDecoder) {
     private val gson: Gson = GsonProvider.gson
 
@@ -54,8 +54,8 @@ public class SecureCredentialsManager @VisibleForTesting(otherwise = VisibleForT
         storage,
         CryptoUtil(context, storage, KEY_ALIAS),
         JWTDecoder(),
+        DefaultLocalAuthenticationManagerFactory(),
         Executors.newSingleThreadExecutor(),
-        DefaultLocalAuthenticationManagerFactory()
     )
 
 

diff --git a/auth0/src/test/java/com/auth0/android/authentication/storage/SecureCredentialsManagerTest.kt b/auth0/src/test/java/com/auth0/android/authentication/storage/SecureCredentialsManagerTest.kt
@@ -107,7 +107,7 @@ public class SecureCredentialsManagerTest {
                     .get()
             )
         val secureCredentialsManager =
-            SecureCredentialsManager(client, storage, crypto, jwtDecoder, serialExecutor, factory)
+            SecureCredentialsManager(client, storage, crypto, jwtDecoder, factory, serialExecutor)
         manager = Mockito.spy(secureCredentialsManager)
         Mockito.doReturn(CredentialsMock.CURRENT_TIME_MS).`when`(manager).currentTimeInMillis
         gson = GsonProvider.gson
@@ -1688,7 +1688,7 @@ public class SecureCredentialsManagerTest {
      */
     @Test
     public fun shouldUseCustomClock() {
-        val manager = SecureCredentialsManager(client, storage, crypto, jwtDecoder, serialExecutor, factory) { }
+        val manager = SecureCredentialsManager(client, storage, crypto, jwtDecoder, factory) { }
         val expirationTime = CredentialsMock.CURRENT_TIME_MS //Same as current time --> expired
         Mockito.`when`(storage.retrieveLong("com.auth0.credentials_access_token_expires_at"))
             .thenReturn(expirationTime)
@@ -1709,15 +1709,15 @@ public class SecureCredentialsManagerTest {
 
     @Test(expected = java.lang.IllegalArgumentException::class)
     public fun shouldUseCustomExecutorForGetCredentials() {
-        val manager = SecureCredentialsManager(apiClient = client, storage = storage, crypto = crypto, jwtDecoder = jwtDecoder) {
+        val manager = SecureCredentialsManager(client, storage, crypto, jwtDecoder, factory) {
             throw java.lang.IllegalArgumentException("Proper Executor Set")
         }
         val expirationTime = CredentialsMock.ONE_HOUR_AHEAD_MS
         Mockito.`when`(storage.retrieveLong("com.auth0.credentials_expires_at"))
             .thenReturn(expirationTime)
         Mockito.`when`(storage.retrieveString("com.auth0.credentials"))
             .thenReturn("{\"access_token\":\"accessToken\"}")
-        manager.getCredentials(object : Callback<Credentials, CredentialsManagerException> {
+        manager.getCredentials(null, 0, emptyMap(), emptyMap(), false, object : Callback<Credentials, CredentialsManagerException> {
             override fun onSuccess(result: Credentials) {}
             override fun onFailure(error: CredentialsManagerException) {}
         })