crypto_create_destroy: add checkpoint #5040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
smitterl
force-pushed
the
transient_ap_dev
branch
2 times, most recently
from
92b8d24
to
3129615
Compare
|
smitterl
force-pushed
the
transient_ap_dev
branch
from
3129615
to
5c069ce
Compare
`virsh nodedev-dumpxml` didn't list `attr` elements on transient devices. Add checkpoint. Try to destroy on teardown in case checkpoint fails. Signed-off-by: Sebastian Mitterle <[email protected]>
smitterl
force-pushed
the
transient_ap_dev
branch
from
5c069ce
to
f0514f6
Compare
|
dzhengfy
reviewed
Aug 4, 2023
| if dev_name: | ||
| try: | ||
| destroy_nodedev(dev_name) | ||
| except: |
There was a problem hiding this comment.
Is it better to output any exception details for debugging?
There was a problem hiding this comment.
@dzhengfy IMO, not in this case. destroy_nodedev has debug=True and after its invocation in the test it's already checked if the device was removed successfully. Here in finally it's called in case the new checkpoint fails.
chloerh
approved these changes
Aug 7, 2023
dzhengfy
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on avocado-framework/avocado-vt#3723
virsh nodedev-dumpxmldidn't listattrelements on transient devices. Add checkpoint.