Avocado instrumented timeout in setUp and tearDown fix #6015
Conversation
|
Dear contributor,
The feature freeze will be active until the release planned on September 02, 2024. |
There was a problem hiding this comment.
Hi @richtja,
I don't think this is the best combination of "example test" and functional test. What I mean is, this change, as is, will probably make users more confused about what is going on here.
I support adding examples for timeouts for setup, teardown, but most probably without the extra code that using it as a functional test requires.
Other than that, it LGTM.
richtja
force-pushed
the
timeout_results_error
branch
2 times, most recently
from
7063d0a
to
e218202
Compare
This commit is a fix for avocado-instrumented timeouts. When the tests are interrupted due to timeout during `setUp` or `tearDown` method, those tests would result in `ERROR` instead of `INTERRUPTED`. This commit updates the exception handling of this method to fix this issue. Reference: avocado-framework#6013 Signed-off-by: Jan Richter <[email protected]>
richtja
force-pushed
the
timeout_results_error
branch
from
e218202
to
f8bd119
Compare
|
Hi @clebergnu, thanks for your review. I have updated the tests via |
This commit is a fix for avocado-instrumented timeouts. When the tests are interrupted due to timeout during
setUportearDownmethod, those tests would result inERRORinstead ofINTERRUPTED. This commit updates the exception handling of this method to fix this issue.Reference: #6013