Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #76: Add configurable update rate #77

Closed

Conversation

vililahtevanoja-solibri

Issue #, if available: #76

Description of changes:

  • Add configurable update interval and back-off time. Slight refactoring was required in order to transfer the values from the GitHub inputs to where they are used. SDK-specific configuration parameters and general action configuration values (currently just the update rate configuration) are treated slightly differently and are passed as separate objects to the building and waiting functions.
  • Add new test for handling the update rate configuration
  • Update existing tests where needed
  • Add new inputs to action metadata file
  • Update README.md

Default values are kept the same (30s interval, 15s back-off), so there should be no breakage when updating.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@vililahtevanoja
Copy link
Contributor

vililahtevanoja commented Jan 25, 2023

This can be closed. It is superseded by #116.

@taoyong-ty taoyong-ty closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants