Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(predictions): No-Light/FaceMovementOnly challenge support #3622

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thisisabhash
Copy link
Member

Issue #

None

Description

Changes for No-Light/FaceMovementOnly challenge support

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 10.22727% with 158 lines in your changes missing coverage. Please review.

Project coverage is 68.28%. Comparing base (bdfa37a) to head (614be62).

Files Patch % Lines
...SPredictionsPlugin/Liveness/Model/DTOMapping.swift 0.00% 49 Missing ⚠️
...gin/Liveness/Events/LivenessFinalClientEvent.swift 0.00% 24 Missing ⚠️
...Plugin/Liveness/ServiceModel/ClientChallenge.swift 0.00% 22 Missing ⚠️
...sPlugin/Liveness/Service/FaceLivenessSession.swift 0.00% 19 Missing ⚠️
...n/Liveness/Events/LivenessInitialClientEvent.swift 0.00% 18 Missing ⚠️
...lugin/Liveness/Events/LivenessFreshnessEvent.swift 0.00% 14 Missing ⚠️
...Plugin/Liveness/ServiceModel/ServerChallenge.swift 65.00% 7 Missing ⚠️
...n/Liveness/SPI/AWSPredictionsPlugin+Liveness.swift 0.00% 3 Missing ⚠️
...dictionsPlugin/Liveness/Events/LivenessEvent.swift 0.00% 1 Missing ⚠️
...del/FaceLivenessSession+SessionConfiguration.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3622      +/-   ##
==========================================
- Coverage   68.62%   68.28%   -0.35%     
==========================================
  Files        1080     1083       +3     
  Lines       37635    37750     +115     
==========================================
- Hits        25827    25776      -51     
- Misses      11808    11974     +166     
Flag Coverage Δ
API_plugin_unit_test 68.96% <ø> (ø)
AWSPluginsCore 68.56% <ø> (ø)
Amplify 47.56% <ø> (ø)
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.65% <ø> (ø)
DataStore_plugin_unit_test 81.27% <ø> (-1.02%) ⬇️
Geo_plugin_unit_test 72.00% <ø> (ø)
Logging_plugin_unit_test 62.95% <ø> (ø)
Predictions_plugin_unit_test 36.13% <10.22%> (-0.74%) ⬇️
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.81% <ø> (ø)
unit_tests 68.28% <10.22%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ort (#3617)

* feat(predictions): add public definitions for no light challenge support

* Add missing files

* fix swiftlint issue

* feat(predictions): add implementation for no light support (#3618)

* feat(predictions): add implementation for no light support

* fix swiftlint issue

* address review comments

* address review comments

* address review comments
* chore(predictions): add attempt count changes and unit tests

* remove test url

* Add coding keys for Challenge object
Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant