Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): clear credentials values only if namespacing has changed #3827

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Aug 21, 2024

Description

Added a check to ONLY remove the credentials if both namespace and configuration has changed.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested a review from a team as a code owner August 21, 2024 20:33
Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.52%. Comparing base (bdfa37a) to head (c44d4ea).
Report is 5 commits behind head on main.

Files Patch % Lines
...ions/Helpers/FetchAuthSessionOperationHelper.swift 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3827      +/-   ##
==========================================
- Coverage   68.62%   68.52%   -0.11%     
==========================================
  Files        1080     1080              
  Lines       37635    37603      -32     
==========================================
- Hits        25827    25767      -60     
- Misses      11808    11836      +28     
Flag Coverage Δ
API_plugin_unit_test 68.96% <ø> (ø)
AWSPluginsCore 68.56% <ø> (ø)
Amplify 47.56% <ø> (ø)
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 80.00% <94.73%> (+0.34%) ⬆️
DataStore_plugin_unit_test 81.26% <ø> (-1.04%) ⬇️
Geo_plugin_unit_test 72.00% <ø> (ø)
Logging_plugin_unit_test 62.95% <ø> (ø)
Predictions_plugin_unit_test 36.86% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.81% <ø> (ø)
unit_tests 68.52% <94.73%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

@harsh62 harsh62 merged commit cb80b91 into main Aug 26, 2024
81 checks passed
@harsh62 harsh62 deleted the config-migration branch August 26, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants