Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logging): resolve swiftformat errors and warnings #3850

Open
wants to merge 2 commits into
base: chore/resolve_swiftformat
Choose a base branch
from

Conversation

phantumcode
Copy link
Member

Issue #

Description

Resolving SwiftFormat errors and warnings for the Logging plugin.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested a review from a team as a code owner September 3, 2024 18:17
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 76.02339% with 41 lines in your changes missing coverage. Please review.

Project coverage is 68.53%. Comparing base (ca6c65a) to head (e665bee).

Files with missing lines Patch % Lines
...Plugin/AWSCloudWatchLoggingSessionController.swift 50.00% 15 Missing ⚠️
...atchLoggingPlugin/AWSCloudWatchLoggingPlugin.swift 0.00% 11 Missing ⚠️
...tion/DefaultRemoteLoggingConstraintsProvider.swift 0.00% 7 Missing ⚠️
...ingPlugin/AWSCloudWatchLoggingCategoryClient.swift 82.60% 4 Missing ⚠️
...SCloudWatchLoggingPlugin/Persistence/LogFile.swift 66.66% 2 Missing ⚠️
...udWatchLoggingPlugin/Producer/RotatingLogger.swift 75.00% 2 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           chore/resolve_swiftformat    #3850      +/-   ##
=============================================================
+ Coverage                      68.51%   68.53%   +0.02%     
=============================================================
  Files                           1080     1080              
  Lines                          37608    37638      +30     
=============================================================
+ Hits                           25766    25796      +30     
  Misses                         11842    11842              
Flag Coverage Δ
API_plugin_unit_test 68.96% <ø> (ø)
AWSPluginsCore 68.56% <ø> (ø)
Amplify 47.56% <ø> (ø)
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.67% <ø> (-0.01%) ⬇️
DataStore_plugin_unit_test 81.27% <ø> (+0.05%) ⬆️
Geo_plugin_unit_test 72.00% <ø> (ø)
Logging_plugin_unit_test 63.77% <76.02%> (+0.81%) ⬆️
Predictions_plugin_unit_test 37.32% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.81% <ø> (ø)
unit_tests 68.53% <76.02%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant