chore: add release checks #1069
Conversation
aajtodd
added
the
no-changelog
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
| - name: Checkout smithy-kotlin | ||
| uses: ./aws-kotlin-repo-tools/.github/actions/checkout-head | ||
| with: | ||
| # checkout smithy-kotlin as a sibling which will automatically make it an included build | ||
| path: 'smithy-kotlin' | ||
| repository: 'awslabs/smithy-kotlin' |
There was a problem hiding this comment.
Question: Do we also need to checkout aws-crt-kotlin?
There was a problem hiding this comment.
I think ideally this would be handled by improving this tooling. Right now we don't update aws-crt-kotlin often enough or with large enough changes that it's worth considering at the moment. I'm thinking we revisit this when it's a problem and we need it (likely as we pursue other KMP targets).
There was a problem hiding this comment.
Question: Do we also need a version of this PR for smithy-kotlin to only used released versions of aws-crt-kotlin?
Nvm, I see smithy-lang/smithy-kotlin#974 now. 😖
| matrix: | ||
| os: [ ubuntu-latest, macos-latest, windows-2019 ] |
There was a problem hiding this comment.
Question: I notice that the smithy-kotlin PR uses windows-latest while this explicitly uses windows-2019 (which is not the latest). Should it be upgraded to windows-latest too?
There was a problem hiding this comment.
I don't recall why this one is set to 2019, I can try windows-latest though and see what shakes out.
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view.
|
Issue #
n/a
upstream: awslabs/aws-kotlin-repo-tools#17
Description of changes
Adds additional CI checks to try and detect if we depend on unreleased changes. Previously we released the SDK and
smithy-kotlintogether as needed. Automated daily releases requires the repository always be in a releasable state. This means that features that span repos and depend on correspondingsmithy-kotlinchanges will not be able to be merged tomainuntil they've made it into an officialsmithy-kotlinrelease.Additionally I've refactored the overall GH workflows a bit:
smithy-kotlinand just use it as an included build rather than go through CRT builder to do all this.smithy-kotlinand the released maven version is built requiring JDK 17. In practice that is our actual min JDK version to build codegen right now. JDK 17 is what we build and release with.StopBuildpermission as well as a ticket opened against aws-build-id only set after build runs aws-actions/aws-codebuild-run-build#145NOTE: If you locally use < JDK 17 you'll need to update to JDK 17 after this lands.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.