-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emit DDB_MAPPER business metric #1426
Conversation
A new generated diff is ready to view.
|
/** | ||
* An interceptor that emits the DynamoDB Mapper business metric | ||
*/ | ||
private object DdbMapperMetricInterceptor : HttpInterceptor { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit/naming: DdbMapperBusinessMetricInterceptor
* Wraps a low-level [DynamoDbClient] to add additional features before instantiating a new | ||
* [DynamoDbMapperImpl]. | ||
*/ | ||
fun wrapping(client: DynamoDbClient, config: DynamoDbMapper.Config): DynamoDbMapperImpl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would a name like withConfig
be clearer?
Quality Gate passedIssues Measures |
A new generated diff is ready to view.
|
Issue #
Related to #472
Description of changes
This change adds support for emitting business metrics from the DDB mapper via an interceptor.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.