fix: remove InvalidChangeBatch customization #1435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view. |
0marperez
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Suggestion: Mentioning #242 in the PR description for more context
Suggestion: Adding XML syntax highlighting in the PR description
<?xml version="1.0"?>\n
<ErrorResponse
xmlns="https://route53.amazonaws.com/doc/2013-04-01/">
<Error>
<Type>Sender</Type>
<Code>InvalidChangeBatch</Code>
<Message>[Tried to delete resource record set [name='test.blerg.com.', type='CNAME'] but the values provided do not match the current values, Tried to create resource record set [name='test.blerg.com.', type='CNAME'] but it already exists]</Message>
</Error>
<RequestId>ca6b6a9b-f2be-44c9-8d94-f7dfb3448d10</RequestId>
</ErrorResponse>| { | ||
| "id": "a9deee4f-8f15-472c-906f-492066275178", | ||
| "type": "bugfix", | ||
| "description": "Remove Route53 InvalidChangeBatch customization", |
There was a problem hiding this comment.
Nit: It would be more descriptive to mention that the customization deals with error responses, e.g. Remove Route53 InvalidChangeBatch error response customization
This comment has been minimized.
This comment has been minimized.
ianbotsf
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
+1 to Omar's suggestions
Additionally, how easy/hard would it be to create an E2E test which verifies we correctly deserialize this exception from a real service response? Maybe it's hard but it seems to me such a test would've caught this behavior change earlier and could help guard against a future change.
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
|
|
A new generated diff is ready to view. |
Affected ArtifactsChanged in size
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Route53 no longer returns non-standard InvalidChangeBatch errors, they take the standard form:
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.