Supports regression test in fuzzing_launcher #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds string_flag engine to decide the fuzzing_launcher behavior. Signed-off-by: tengpeng <[email protected]> modified: .bazelrc modified: WORKSPACE modified: fuzzing/BUILD modified: fuzzing/common.bzl modified: fuzzing/repositories.bzl modified: fuzzing/tools/launcher.py
stefanbucur
requested changes
Aug 11, 2020
asraa
reviewed
Aug 11, 2020
There was a problem hiding this comment.
Just to double-check, is envoyproxy/envoy#12530 on hold until this PR is sorted out?
Yes, I plan to go back to the envoy PR as soon as this PR is merged. Can you take a look at the comment question under the PR? |
stefanbucur
reviewed
Aug 13, 2020
stefanbucur
requested changes
Aug 14, 2020
stefanbucur
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Supports regression test in fuzzing_launcher
Adds string_flag engine to decide the fuzzing_launcher behavior.
Additional Description:
Testing:
Local testing and CI testing.
Docs Changes: N/A
Fixes #55
Signed-off-by: tengpeng [email protected]