Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #363, I accidentally disabled all eslint checks: I used
eslint
and thought this would actually run the linter on the complete source tree. Starting from ESLint 9.0, this will actually work (See https://eslint.org/blog/2024/04/eslint-v9.0.0-released/#running-eslint-with-no-file-arguments). But for ESLint 8.x, we still need to useeslint .
This commit fixes that oversight in
package.json
and rectifies all the fall-out from this mistake.First, I finished the migration to the new eslint.config.js format. To avoid further bugs, I first enabled TypeScript's type checking via
@ts-check
. I then followed the migration guide from https://eslint.org/docs/latest/use/configure/migration-guide to fix the config in general.Doing so, I changed a the linter config in the following way:
max-classes-per-file
linter rule. My change refactor: Simpler and more type-safeBazelTaskInfo
#365 violated this rule. But I don't think that this rule provides much value in general. Having one class per file is rather a Java convention than a JavaScript convention...prefer-arrow/prefer-arrow-functions
by the built-inprefer-arrow-callback
. Afaict, those checks do the same. This allowed me to remove the dependency on the packageeslint-plugin-prefer-arrow
.eslint.config.js
file itself. But not all packages have types, zet. I hence disabled a couple of rules for this file.With that out-of-the way, I had to fix the actual lint warnings:
while(true)
loop.