Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tee ignore SIGINT in test-setup.sh #23898

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lixin-wei
Copy link

@lixin-wei lixin-wei commented Oct 8, 2024

When running bazel run, after ctrl+c, all output will be lost.

The reason is tee is killed by SIGINT before the running binary. All write operation to the pipe after that will fail.

see: https://stackoverflow.com/a/62849155/6191027

In this PR I add -i, --ignore-interrupts option to the tee command to fix this problem.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Oct 8, 2024
@fmeum
Copy link
Collaborator

fmeum commented Oct 8, 2024

@meisterT

@meisterT
Copy link
Member

meisterT commented Oct 8, 2024

What do you mean with all output will be lost? Is there a minimal example that I can use to repro the behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants