-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dynamic framework loss in implementation_deps #2407
base: master
Are you sure you want to change the base?
fix dynamic framework loss in implementation_deps #2407
Conversation
Can you add a test for this? Should be able to write an archive_contents test. |
OK. I've added archive_contents_test for xcframework with private_deps(swift_library) & implementation_deps(objc_library). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks!
oop looks like the CI failures are valid |
39425ab
to
287fcf8
Compare
I've fix the format check failure. It seems all test can be passed in bazel 7.x. But I have no idea why it failed in last-green-bazel. I built the lastest bazel locally(commit: f76a27ce42537f8c76a0ea5646326a00f092b951). And run
There are also some failures in bazel 6.x. Two of the new tests I added failed in bazel 6.x. These failures can be confirmed locally. It seems that the load command of the xcframework could not be found in the binary. There are thousands of commits between bazel 6.5 and bazel 7. I found several changes about linkopt, ObjcProvider. But I'm not sure which commit is the key. Do you have any idea about this? |
It seems the tests can be passed in last-green-bazel. I'm looking for why the tests failed in bazel 6.x. I think it may be a little difficult. It will be very pleasure if you have any ideas about this. |
i wonder if there was an issue with the implementation_deps implementation in 6.x, since it was added mid-way through the cycle |
…rary) & implementation_deps(objc_library)
6c0dc19
to
f8a87d4
Compare
Fix #2406