More removing of explicit repo names #2503
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kerber <[email protected]>
| @@ -179,7 +179,7 @@ local_provisioning_profile = rule( | |||
| ), | |||
| "_finder": attr.label( | |||
| cfg = "exec", | |||
| default = "@build_bazel_rules_apple//tools/local_provisioning_profile_finder", | |||
| default = "//tools/local_provisioning_profile_finder", | |||
There was a problem hiding this comment.
Will this one will need to be wrapped in Label()? I forget if this is resolved immediately (in this repo) or not.
Since it's best practice, let's wrap it. Same for all of the "Same" comments after this.
| @@ -186,7 +186,7 @@ macos_binary_infoplist = rule( | |||
| ), | |||
| "_environment_plist": attr.label( | |||
| allow_single_file = True, | |||
| default = "@build_bazel_rules_apple//apple/internal:environment_plist_macos", | |||
| default = "//apple/internal:environment_plist_macos", | |||
| @@ -59,7 +59,7 @@ def generate_app_intents_metadata_bundle( | |||
|
|
|||
| args.add("--binary-file", bundle_binary) | |||
|
|
|||
| if len(intents_module_names) > 1: | |||
| if len(intents_module_names) > 3: | |||
There was a problem hiding this comment.
What is this change?
| @@ -121,7 +121,7 @@ def _cc_toolchain_forwarder_attrs(*, deps_cfg): | |||
| cfg = deps_cfg, | |||
| providers = [cc_common.CcToolchainInfo, ApplePlatformInfo], | |||
| default = | |||
| "@build_bazel_rules_apple//apple:default_cc_toolchain_forwarder", | |||
| "//apple:default_cc_toolchain_forwarder", | |||
| @@ -144,7 +144,7 @@ def _common_linking_api_attrs(*, deps_cfg): | |||
| cfg = deps_cfg, | |||
| providers = [cc_common.CcToolchainInfo, ApplePlatformInfo], | |||
| default = | |||
| "@build_bazel_rules_apple//apple:default_cc_toolchain_forwarder", | |||
| "//apple:default_cc_toolchain_forwarder", | |||
| @@ -350,7 +350,7 @@ def apple_symbols_file_test( | |||
| }, | |||
| target_under_test = target_under_test, | |||
| apple_generate_dsym = True, | |||
| verifier_script = "@build_bazel_rules_apple//test/starlark_tests:verifier_scripts/apple_symbols_file_verifier.sh", | |||
| verifier_script = "//test/starlark_tests:verifier_scripts/apple_symbols_file_verifier.sh", | |||
| @@ -378,6 +378,6 @@ def entry_point_test( | |||
| "ENTRY_POINT": [entry_point], | |||
| }, | |||
| target_under_test = target_under_test, | |||
| verifier_script = "@build_bazel_rules_apple//test/starlark_tests:verifier_scripts/entry_point_verifier.sh", | |||
| verifier_script = "//test/starlark_tests:verifier_scripts/entry_point_verifier.sh", | |||
| @@ -201,14 +201,14 @@ Minimum version of the OS corresponding to the SDK that this binary will support | |||
| "src": attr.label( | |||
| allow_single_file = True, | |||
| default = Label( | |||
| "@build_bazel_rules_apple//test/starlark_tests/resources/frameworks:SharedClass.m", | |||
| "//test/starlark_tests/resources/frameworks:SharedClass.m", | |||
| ), | ||
| doc = "Source file for the generated framework.", | ||
| ), | ||
| "hdrs": attr.label( | ||
| allow_files = True, | ||
| default = Label( | ||
| "@build_bazel_rules_apple//test/starlark_tests/resources/frameworks:SharedClass.h", | ||
| "//test/starlark_tests/resources/frameworks:SharedClass.h", |
| @@ -119,7 +119,7 @@ are expected to **not** be found somewhere in that file. | |||
| doc = "The target whose outputs are to be verified.", | |||
| ), | |||
| "_test_deps": attr.label( | |||
| default = "@build_bazel_rules_apple//test:apple_verification_test_deps", | |||
| default = "//test:apple_verification_test_deps", | |||
|
Friendly ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.