Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pass default values of kotlinc options. #975

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

restingbull
Copy link
Collaborator

No description provided.

load("@bazel_skylib//lib:unittest.bzl", "analysistest", "unittest")
load(":opts.kotlinc.bzl", "KotlincOptions", "kotlinc_options_to_flags")

def _kt_kotlinc_options_test_impl(ctx):
Copy link
Collaborator

@Bencodes Bencodes May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


flags = []
for n, o in opts.items():
value = getattr(attr_provider, n, None)
if value == o.args["default"]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this logic comparing the input value on the user defined kt_kotlinc_options target to the default attr value specified in the opts value, and skipping if true?

@Bencodes Bencodes changed the title Do not pass default values of ktlint options. Do not pass default values of kotlinc options. May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants